Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Argo Rollouts #145

Closed
jthomperoo opened this issue Aug 9, 2021 · 3 comments · Fixed by #152
Closed

Support Argo Rollouts #145

jthomperoo opened this issue Aug 9, 2021 · 3 comments · Fixed by #152

Comments

@jthomperoo
Copy link
Owner

Is your feature request related to a problem? Please describe.
The Custom Pod Autoscaler would be better if it could provide support for Argo Rollouts.
https://argoproj.github.io/argo-rollouts/

Describe the solution you'd like
Argo Rollouts should be supported in the same way that core Kubernetes resources such as a Deployment or ReplicaSet is supported.

Additional context
This was raised as part of a feature request for the predictive-horizontal-pod-autoscaler as part of issue jthomperoo/predictive-horizontal-pod-autoscaler#52.
@jthomperoo
Copy link
Owner Author

Currently blocked by argoproj/argo-workflows#6750.

@jthomperoo jthomperoo mentioned this issue Dec 27, 2021
Merged
@jthomperoo
Copy link
Owner Author

Perhaps not actually blocked by above, downgrading to K8s client v0.21.8 seems to work.

@jthomperoo jthomperoo mentioned this issue Dec 27, 2021
Closed
@jthomperoo
Copy link
Owner Author

This change is now included in v2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Argo rollouts jthomperoo/custom-pod-autoscaler
1 participant
@jthomperoo