Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-flags-array should ignore buildFlagsArray #37

Open
SuperSandro2000 opened this issue Feb 12, 2021 · 3 comments
Open

no-flags-array should ignore buildFlagsArray #37

SuperSandro2000 opened this issue Feb 12, 2021 · 3 comments

Comments

@SuperSandro2000
Copy link
Contributor

I just noticed that buildFlagsArray gets flagged by no-flags-array (NixOS/nixpkgs#112814 (comment)). Even thou it is valid I think we want to ignore that or change buildGoModule to use nix instead of bash.

@jtojnar
Copy link
Owner

jtojnar commented Feb 12, 2021

Well, Go packages are precisely what lead me to introduce the check in the first place (see NixOS/nixpkgs#112054). As soon as someone adds a second flag, the whole thing will break.

@jtojnar
Copy link
Owner

jtojnar commented Feb 12, 2021

Alternative would be only showing the error once there is actually more than one flag, since it technically works with a single one.

@zowoq
Copy link

zowoq commented Feb 13, 2021

Alternative would be only showing the error once there is actually more than one flag

Doing this would be good for now until we come up with a proper fix for buildGo{Module,Package}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants