Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unclear-gpl: False negative for “only” licenses #4

Closed
jtojnar opened this issue Oct 13, 2020 · 2 comments · Fixed by NixOS/nixpkgs#107417
Closed

unclear-gpl: False negative for “only” licenses #4

jtojnar opened this issue Oct 13, 2020 · 2 comments · Fixed by NixOS/nixpkgs#107417
Labels
bug Something isn't working

Comments

@jtojnar
Copy link
Owner

jtojnar commented Oct 13, 2020

We are comparing structurally and gpl3 == gpl3Only.

{ stdenv
}:

stdenv.mkDerivation {
  name = "unclear-gpl-gpl3-only";

  src = ../fixtures/make;

  meta.license = stdenv.lib.licenses.gpl3Only;
}
@jtojnar jtojnar added the bug Something isn't working label Oct 13, 2020
@SuperSandro2000
Copy link
Contributor

Is this related to

When evaluating attribute ‘luna-icons’:                                                                                                                                                     warning: unclear-gpl                                                                                                                                                                        `gpl3` is a deprecated license, check if project uses `gpl3Plus` or `gpl3Only` and change `meta.license` accordingly.                                                                                                                                                                                                                                                                   Near /home/hotpi/.cache/nixpkgs-review/pr-107050/nixpkgs/pkgs/data/icons/luna-icons/default.nix:54:5:
   |
54 |     license = [ licenses.gpl3Only ];
   |     ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

@jtojnar
Copy link
Owner Author

jtojnar commented Dec 22, 2020

Yes, that is this issue. NixOS/nixpkgs#107417 will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants