Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement newUntitled #14

Merged
merged 2 commits into from Apr 12, 2022
Merged

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Apr 12, 2022

Implement the newUntitled method.

I am reusing the same pattern as the classic JupyterLab file browser where new folders are name Untitled Folder {N} and new files are named untitled{N}.{ext}

newuntitled

@martinRenou martinRenou marked this pull request as draft April 12, 2022 08:48
@martinRenou
Copy link
Member Author

I see an issue when creating an untitled folder, it gets created properly but JupyterLab seems to be trying to select it in the browser UI before refreshing

@martinRenou martinRenou marked this pull request as ready for review April 12, 2022 08:56
@martinRenou
Copy link
Member Author

martinRenou commented Apr 12, 2022

I see an issue when creating an untitled folder, it gets created properly but JupyterLab seems to be trying to select it in the browser UI before refreshing

This actually was an issue with the get output where the directory name was not right, resulting in JupyterLab trying to select a directory that does not exist.

This should be good to go now!

newdir

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 8e56ca1 into jupyterlab-contrib:main Apr 12, 2022
@jtpio
Copy link
Member

jtpio commented Apr 12, 2022

Making a 0.3.0 release with this.

@martinRenou martinRenou deleted the newuntitled branch April 12, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants