Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular-snap doesn't work together with ngSticky #113

Closed
anatoly314 opened this issue May 30, 2016 · 4 comments
Closed

Angular-snap doesn't work together with ngSticky #113

anatoly314 opened this issue May 30, 2016 · 4 comments

Comments

@anatoly314
Copy link

Duplicate my question from SO here http://stackoverflow.com/questions/37527823/angular-snap-doesnt-work-together-with-ngsticky


trying to use together Angular-Snap with ngSticky but it doesn't work, panel which should stay sticky is being scrolled.

I've prepared two examples:

You can expand in both examples accordion panel and try to scroll to see the difference.

If I remove in 1st, non-working example angular-snap.css file it begins to work, but obviously I need it. I couldn't debug this issue further, so any help would be appreciated.

@jtrussell
Copy link
Owner

jtrussell commented May 31, 2016

Just curious - have you tried using:

  • angular-snap-only.css - from this repo
  • snap.css - from the Snap.js repo

rather than the combined angular-snap.css? IIRC the combined css file also includes some extra things (e.g. smooth scrolling) that may be getting in the way here. In general I'd recommend using the dedicated CSS files for each library independently. We're just providing a bundled version here for convenience and backward compatibility.

If that still doesn't work it'll at least tell us if the issue lies in the Snap.js css or ours.

@anatoly314
Copy link
Author

anatoly314 commented May 31, 2016

Yes, it has solved this issue. Thank you very much!
Link to working example: https://plnkr.co/edit/rKxHTDCK6qjFFumrbxnn

@anatoly314
Copy link
Author

Only now seen that angular-snap-only.css and snap.css not enough, right menu now shown (left menu I haven't checked), you need to add manually:

.snap-drawer-left {
  left: 0;
}
.snap-drawer-right {
  right: 0;
}

@jtrussell
Copy link
Owner

It looks like there rules are in place: https://github.com/jakiestfu/Snap.js/blob/develop/snap.css#L55-L63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants