Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: Not working links in documentation #168

Merged
merged 2 commits into from Sep 5, 2023
Merged

[DOC]: Not working links in documentation #168

merged 2 commits into from Sep 5, 2023

Conversation

synchon
Copy link
Collaborator

@synchon synchon commented Jul 27, 2023

Different links in the documentation are not working.
For example under julearn.api.run_cross_validation (https://juaml.github.io/julearn/v0.2.3/api.html) this link (https://juaml.github.io/julearn/input.html) appears multiple times but leads to a 404.

@verakye verakye added the bug Something isn't working label Aug 17, 2022
@samihamdan samihamdan added documentation Improvements or additions to documentation and removed bug Something isn't working labels Aug 17, 2022
@fraimondo fraimondo added this to the v0.2.5 milestone Aug 29, 2022
@fraimondo
Copy link
Contributor

Hey @synchon! Can you check this? I think it might be related to how links are included in the docstring. We need to find a way of doing this that works with the docs multiversion.

@synchon
Copy link
Collaborator

synchon commented Aug 29, 2022

Sure, I'll take a look.

@fraimondo fraimondo modified the milestones: v0.2.5, v0.3.0 Apr 6, 2023
@fraimondo fraimondo self-assigned this Apr 6, 2023
@github-actions
Copy link

github-actions bot commented Jul 27, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-09-05 12:13 UTC

@synchon synchon requested a review from fraimondo July 28, 2023 04:52
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #168 (5667e93) into main (00e8c27) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #168   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           
Flag Coverage Δ
docs 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@synchon synchon changed the title [DOC] Not working links in documentation [DOC]: Not working links in documentation Aug 9, 2023
@synchon synchon merged commit 3f3cb41 into main Sep 5, 2023
16 of 20 checks passed
@synchon synchon deleted the docs/fix-links branch September 5, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants