New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] CBPM not aligned with paper #170
Comments
the code from authors is available here: https://www.nitrc.org/projects/bioimagesuite/ (see file |
Thanks for the issue @samihamdan! I am using the CBPM implementation and would like to see if/what difference sum vs mean makes. And would also like to use it as the authors intended :) If I can help adjusting that, let me know :) |
The Here is empirical demonstration of this using R ;)
|
Nice, thank you! |
This PR: #221 introduces sum as default option for cbpm, but still allows other aggregation functions. |
The CBPM method we implemented has slight variations from the original: using the mean instead of sum for summation; the weighting might also not be aligned.
While this should not make a fundamental difference, users should at least have the option to exactly follow the paper.
The text was updated successfully, but these errors were encountered: