Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't scroll when too big for viewport #4

Closed
tracker1 opened this issue Jul 12, 2016 · 2 comments
Closed

Doesn't scroll when too big for viewport #4

tracker1 opened this issue Jul 12, 2016 · 2 comments

Comments

@tracker1
Copy link

If you open the second modal in the demo, then shrink the window down, the modal's area should scroll..

Here's an example[1] I have for a modal that works as one might expect. When the modal is open, the page itself doesn't scroll, for those browsers/platforms with a visible scrollbar, the page is adjusted as appropriate, and when the viewport is too small for the modal (vertically) you can scroll just the modal portion of the viewport.

I have the structure for the outline here[2], as well as the complementing styles[3].

[1] http://tracker1.github.io/md-datepicker/
[2] https://github.com/tracker1/md-datepicker/blob/master/_src/DatePickerModal/feature/main/index.js
[3] https://github.com/tracker1/md-datepicker/blob/master/_src/DatePickerModal/feature/main/style.scss

@juanbrujo
Copy link
Owner

Thanks for the detailed point @tracker1. tinyModal was created as a modal-wrapper, delivering a very basic CSS markup to use it as starter. The problem you show is easily resolved adding an inner <div> container and adding, for example, overflow-y: auto;. I'll see if I add it to the default markup and create a new release.

Thanks again.

@juanbrujo
Copy link
Owner

resolved fa2b3da

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants