Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on 1.19.3 when “Show Subtitles” turns on #198

Closed
lonefelidae16 opened this issue Dec 19, 2022 · 0 comments · Fixed by #199
Closed

Crash on 1.19.3 when “Show Subtitles” turns on #198

lonefelidae16 opened this issue Dec 19, 2022 · 0 comments · Fixed by #199

Comments

@lonefelidae16
Copy link
Contributor

Hi👋

I got a crash on Fabric MC1.19.3 with 1.5.2.
crash-2022-12-19_09.16.20-client.txt

From yarn mappings, class_359 means SubtitlesHud, then I examined the code and the cause of this crash became apparent. It appears that the type is failing to cast.
I have fixed it so that local variables accept the correct type. I will create new PR of this hotfix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

correction of argument types
1 participant
@lonefelidae16