Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage report as new step in CI #117

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Add coverage report as new step in CI #117

wants to merge 14 commits into from

Conversation

morcuended
Copy link
Collaborator

@morcuended morcuended commented Jun 13, 2024

  • Upload coverage report after each code modification
  • Add dependanbot to keep action versions up to date
  • Update action versions
  • Typos

closes #45

@morcuended morcuended marked this pull request as draft June 13, 2024 10:18
@morcuended
Copy link
Collaborator Author

Ready. Now coverage is reported in every pull request under the Actions tab.

image

@morcuended morcuended marked this pull request as ready for review June 18, 2024 10:03
@morcuended morcuended requested a review from juanep97 June 18, 2024 10:03
@morcuended
Copy link
Collaborator Author

Still I think the coverage report should be posted automatically in a comment instead of the Actions page.

@morcuended morcuended marked this pull request as draft June 18, 2024 12:56
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this keep the CI up to date?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It inspects the CI actions regularly checking if there are new versions. If it finds it, the dependantbot creates a PR with the version bump. If you agree with the change, just merge it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to this I'm actually seeing that in the Security tab, there is this same information https://github.com/juanep97/iop4/security/dependabot. Some warnings on packages that should be updated

juanep97
juanep97 previously approved these changes Jun 18, 2024
Copy link
Owner

@juanep97 juanep97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

We can try to add the result as a comment in this PR or a new one, as you prefer.

@morcuended
Copy link
Collaborator Author

We can try to add the result as a comment in this PR or a new one, as you prefer.

Let's do it here. I will explore the two options (an already existing action that upload the coverage report as a comment or use GH action script to create the comment manually)

@juanep97
Copy link
Owner

@morcuended
Copy link
Collaborator Author

Would something like https://github.com/orgs/community/discussions/69944#discussioncomment-7269357 work?

Could be, to be tried. Maybe we can generate the table in markdown format as shown above and post it as a comment.

The problem with the action I just tried py-cov-action/python-coverage-comment-action is that self-hosted runners need extra configuration to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add coverage report and integration with codecov
2 participants