-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage report as new step in CI #117
base: main
Are you sure you want to change the base?
Conversation
Still I think the coverage report should be posted automatically in a comment instead of the Actions page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this keep the CI up to date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It inspects the CI actions regularly checking if there are new versions. If it finds it, the dependantbot creates a PR with the version bump. If you agree with the change, just merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see e.g. cta-observatory/magic-cta-pipe#198
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to this I'm actually seeing that in the Security tab, there is this same information https://github.com/juanep97/iop4/security/dependabot. Some warnings on packages that should be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
We can try to add the result as a comment in this PR or a new one, as you prefer.
Let's do it here. I will explore the two options (an already existing action that upload the coverage report as a comment or use GH action script to create the comment manually) |
Would something like https://github.com/orgs/community/discussions/69944#discussioncomment-7269357 work? |
Could be, to be tried. Maybe we can generate the table in markdown format as shown above and post it as a comment. The problem with the action I just tried |
closes #45