Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ACLs although going one way, are discoverable by the "dst". #1961

Closed
2 of 4 tasks
mifraburneo opened this issue May 28, 2024 · 1 comment
Closed
2 of 4 tasks
Labels
bug Something isn't working

Comments

@mifraburneo
Copy link

mifraburneo commented May 28, 2024

Is this a support request?

  • This is not a support request

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I have this users as an example:
image

As well as this ACL:
image

So now currently:
Mifra's (admin's) machines are able to see all the network's machines.
BUT
Any user's machines are able to see Mifra's machines as well (aka discover via UI or tailscale status, providing information like IP and if they're up or not) although it seems that they're not able to ping nor ssh, etc.

Expected Behavior

I expect that the only rule in the ACL is considered.
That is, only the admin group members can see and access other machines and not viceversa.

Steps To Reproduce

Create 3 users at least and assign an ACL in the same matter as shown above.

Environment

- OS: Ubuntu 24.4
- Headscale version: 0.22.3
- Tailscale version: indifferent, but 1.64 for example

Runtime environment

  • Headscale is behind a (reverse) proxy
  • Headscale runs in a container

Anything else?

No response

@mifraburneo mifraburneo added the bug Something isn't working label May 28, 2024
@kradalby
Copy link
Collaborator

kradalby commented May 30, 2024

Hi, this is intended behaviour, if one of two machines can reach each other, they will be visible in each others map (and therefore UI/status). Only nodes that cannot connect to each other at all will be fully removed from the list.

Access should be correctly limited, but they wont be removed from the list, from what I understand, they can see, but not access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants