Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not bug, but Enhancement]Rename Machine won't change the name's record in [nodes ls] #647

Closed
1itt1eB0y opened this issue Jun 16, 2022 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@1itt1eB0y
Copy link

I changed my kali(ID:2) to pi.
It says success and it was changed in my clients.
But it is still the old name in headscale's command output.
图片
图片

@1itt1eB0y 1itt1eB0y added the bug Something isn't working label Jun 16, 2022
@1itt1eB0y 1itt1eB0y changed the title Rename Machine won't change the name's record in [nodes ls] [Not bug, but Enhancement]Rename Machine won't change the name's record in [nodes ls] Jun 16, 2022
@1itt1eB0y
Copy link
Author

I noticed there is a given_name in DB, so why not make it list in the output of cli?

@huskyii
Copy link
Contributor

huskyii commented Jul 22, 2022

Observe same issue, it's pretty confusing, I'd suggest add a Hostname column in the nodes ls outputs.
And the mapping is:
machine.Name -> Hostname
machine.GivenName -> Name

I've implemented this enhancement, @kradalby if you think this is ok, I can open a PR

@kradalby
Copy link
Collaborator

Yes please

@kradalby kradalby added this to the v0.16.0 milestone Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants