fix: remove legacy unused settings

juanjoDiaz · Feb 10, 2024 · bbe451e · bbe451e
1 parent 2f1e932
commit bbe451e
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 11 deletions.
diff --git a/dist/cdn/plainjs/BaseParser.js b/dist/cdn/plainjs/BaseParser.js
@@ -27,7 +27,7 @@ var JSON2CSVBase = class {
    * Check passing opts and set defaults.
    *
    * @param {Json2CsvOptions} opts Options object containing fields,
-   * delimiter, default value, quote mark, header, etc.
+   * delimiter, default value, header, etc.
    */
   preprocessOpts(opts) {
     const processedOpts = Object.assign(

diff --git a/packages/cli/src/json2csv.ts b/packages/cli/src/json2csv.ts
@@ -36,6 +36,16 @@ const { readFile, writeFile } = fsPromises;
 
 type InputOptions = { ndjson: boolean; eol: string };
 type OutputOptions = TablePrinterOptions & { pretty: boolean };
+type FormattersOptions = {
+  excelStrings: boolean;
+  quote: string;
+  escapedQuote: string;
+};
+type TransformsOptions = {
+  flattenObjects: boolean;
+  flattenArrays: boolean;
+  flattenSeparator: string;
+} & { unwind: true | string; unwindBlank: boolean };
 
 type Options = {
   input: string;
@@ -46,11 +56,9 @@ type Options = {
   Omit<ParserOptions<unknown, unknown>, 'fields' | 'withBOM'> & {
     fields?: Array<string> | string;
     withBom: boolean;
-  } & StreamParserOptions & {
-    flattenObjects: boolean;
-    flattenArrays: boolean;
-    flattenSeparator: string;
-  } & { unwind: true | string; unwindBlank: boolean };
+  } & StreamParserOptions &
+  FormattersOptions &
+  TransformsOptions;
 
 const program = new Command();
 program

diff --git a/packages/plainjs/src/BaseParser.ts b/packages/plainjs/src/BaseParser.ts
@@ -62,11 +62,8 @@ export interface Json2CSVBaseOptions<TRaw, T> {
   fields?: Array<string | FieldInfo<T, unknown>>;
   ndjson?: boolean;
   defaultValue?: string;
-  quote?: string;
-  escapedQuote?: string;
   delimiter?: string;
   eol?: string;
-  excelStrings?: boolean;
   header?: boolean;
   includeEmptyRows?: boolean;
   withBOM?: boolean;
@@ -102,7 +99,7 @@ export default abstract class JSON2CSVBase<
    * Check passing opts and set defaults.
    *
    * @param {Json2CsvOptions} opts Options object containing fields,
-   * delimiter, default value, quote mark, header, etc.
+   * delimiter, default value, header, etc.
    */
   protected preprocessOpts(
     opts?: Json2CSVBaseOptions<TRaw, T>,

diff --git a/packages/plainjs/src/Parser.ts b/packages/plainjs/src/Parser.ts
@@ -10,7 +10,7 @@ export default class JSON2CSVParser<
   TRaw extends object,
   T extends object,
 > extends JSON2CSVBase<TRaw, T> {
-  constructor(opts?: Readonly<Json2CSVBaseOptions<TRaw, T>>) {
+  constructor(opts?: Readonly<Omit<Json2CSVBaseOptions<TRaw, T>, 'ndjson'>>) {
     super(opts);
   }