Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace operators.aggregate() with functional.DelayedAggregation #16

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

juanmc2005
Copy link
Owner

@juanmc2005 juanmc2005 commented Dec 16, 2021

Issue

This PR addresses issue #12

Changelog

  • Decouple RxPY and output window aggregation
  • Remove function operators.aggregate()
  • Add class functional.DelayedAggregation
  • Document DelayedAggregation and add an example
  • Fix incorrect resolution in functional.FrameWiseModel causing chunks to be slightly shorter than 5s (might be related to My output is different from expected_outputs #15)

@juanmc2005 juanmc2005 added bug Something isn't working documentation Improvements or additions to documentation feature New feature or request labels Dec 16, 2021
@juanmc2005 juanmc2005 self-assigned this Dec 16, 2021
@juanmc2005 juanmc2005 merged commit a96e7ae into develop Dec 17, 2021
@juanmc2005 juanmc2005 deleted the feat/fn_aggregation branch December 17, 2021 08:01
@juanmc2005 juanmc2005 mentioned this pull request Jan 7, 2022
juanmc2005 referenced this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant