Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using with python > 3.8 #166

Closed
ethanzrd opened this issue Aug 1, 2023 · 8 comments
Closed

Using with python > 3.8 #166

ethanzrd opened this issue Aug 1, 2023 · 8 comments
Labels
question Further information is requested

Comments

@ethanzrd
Copy link

ethanzrd commented Aug 1, 2023

Hey, is it feasible to create the conda environment without anchoring to Python 3.8? Ideally, I would like to update it to use Python 3.10. I'm planning to use it alongside WhisperX, which anchors to Python 3.10 for its conda environment, and this raised the question for me.

If it's currently not possible, I'd love to know how we can make it work. I'm more than happy to contribute to the project to help with this transition :)

@juanmc2005 juanmc2005 added the question Further information is requested label Aug 9, 2023
@juanmc2005
Copy link
Owner

Hi @ethanzrd, it should be possible to use python 3.10. Feel free to leave a comment or raise a new issue if you find any incompatibilities.

@ethanzrd
Copy link
Author

ethanzrd commented Aug 10, 2023

Hey @juanmc2005, I've noticed that with versions higher than 3.8, it's not possible to import directly from diart as the __init__.py file is empty. Can you let me know if it's the same on your end?

By the way, I'd recommend testing Diart in an application where faster-whisper is also being used, I've had a lot of issues. I managed to fix it, but I think that it's worth looking into with the popularity of faster-whisper.

@juanmc2005
Copy link
Owner

@ethanzrd I've been using v0.7 with python 3.10 and didn't get any errors. What do you see exactly?

I'm aware of faster-whisper and it's definitely something I would like to add! Lately I haven't had the time to develop the library.

@ethanzrd
Copy link
Author

Appreciate the quick response, @juanmc2005
I anchor to a different Python version when creating the environment: conda create -n diart python=3.10
And then, when I try to do something like from diart import OnlineSpeakerDiarization, it can't find OnlineSpeakerDiarization since the __init__.py file is empty.

What do you mean by adding faster-whisper? In terms of compatibility or native support? Let me know if there's anything I can do to speed this up!

By the way, WhisperX uses PyTorch 2.0 (e.g. conda install pytorch==2.0.0 torchaudio==2.0.0 pytorch-cuda=11.8 -c pytorch -c nvidia), do you reckon there'd be any compatibility issues?

@juanmc2005
Copy link
Owner

I anchor to a different Python version when creating the environment: conda create -n diart python=3.10
And then, when I try to do something like from diart import OnlineSpeakerDiarization, it can't find OnlineSpeakerDiarization since the __init__.py file is empty.

the __init__.py file is not empty, see here.

What do you mean by adding faster-whisper? In terms of compatibility or native support? Let me know if there's anything I can do to speed this up!

I mean it could be used as the default implementation of Whisper in the new Transcription pipelines I'm planning to include in v0.8. Right now it's using the official implementation from OpenAI, which is considerably slower.

By the way, WhisperX uses PyTorch 2.0 (e.g. conda install pytorch==2.0.0 torchaudio==2.0.0 pytorch-cuda=11.8 -c pytorch -c nvidia), do you reckon there'd be any compatibility issues?

I don't think so but you'll get warnings from pip because the requirements file is not up to date with these new versions. This is something I have in my to-do list but haven't had the time to address.

@Ramzes30765
Copy link

Hello @juanmc2005 , I'm trying to install diart but have some during this. Can you please help me?

Here is the error code:
ERROR: Exception: Traceback (most recent call last): File "/home/ramzes/my_projects/exmo/myenv/lib/python3.10/site-packages/pip/_internal/cli/base_command.py", line 165, in exc_logging_wrapper status = run_func(*args) File "/home/ramzes/my_projects/exmo/myenv/lib/python3.10/site-packages/pip/_internal/cli/req_command.py", line 205, in wrapper return func(self, options, args) File "/home/ramzes/my_projects/exmo/myenv/lib/python3.10/site-packages/pip/_internal/commands/install.py", line 389, in run to_install = resolver.get_installation_order(requirement_set) File "/home/ramzes/my_projects/exmo/myenv/lib/python3.10/site-packages/pip/_internal/resolution/resolvelib/resolver.py", line 188, in get_installation_order weights = get_topological_weights( File "/home/ramzes/my_projects/exmo/myenv/lib/python3.10/site-packages/pip/_internal/resolution/resolvelib/resolver.py", line 276, in get_topological_weights assert len(weights) == expected_node_count AssertionError

@juanmc2005
Copy link
Owner

@Ramzes30765 how did you install diart? could you provide a minimal reproducible example so I can try to get the same error on my end?

@juanmc2005
Copy link
Owner

Closing as it's been inactive for a while. Feel free to reopen if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants