Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Message Improvements #791

Closed
kmaehashi opened this issue May 22, 2014 · 2 comments
Closed

Log Message Improvements #791

kmaehashi opened this issue May 22, 2014 · 2 comments

Comments

@kmaehashi
Copy link
Member

Some log messages from Jubatus are hard for operators to understand.

  1. Insufficient information
    Some error messages are not self-descriptive.
    For example, just saying "unexpected error" is insufficient. We should clearly state the stituation, like "unexpected exception thrown in mix".
  2. Hard to determine the problem
    Similar to 1. The same error messages should not be used more than twice.
    For example, only printing e.what() is done in many location (1, 2, etc). We should give them different prefix.
  3. Multiple logs for one situation
    We should print one log for each situation.
    For example, these 3 lines should be unified (or give some common prefix): https://github.com/jubatus/jubatus/blob/b05ad7ffe4a501751645b7e450522bb1e283acc4/jubatus/server/jubavisor/process.cpp#L129-131
  4. Format is not unified
    For example, this line print "expected, actual" order, whereas this line prints "actual, expected" order. We should unify them.
@kumagi
Copy link
Member

kumagi commented May 23, 2014

👍
This is serious problem.

@kmaehashi
Copy link
Member Author

Fixed via jubatus/jubatus_core#12 and #822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants