Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Invalid semver marked as valid #104

Open
mattfarina opened this issue Mar 22, 2021 · 3 comments
Open

bug: Invalid semver marked as valid #104

mattfarina opened this issue Mar 22, 2021 · 3 comments

Comments

@mattfarina
Copy link

Try the version 1.0.0-dev.01 and it will show it is valid. Except the spec says of pre-releases:

Numeric identifiers MUST NOT include leading zeroes.

@trafium
Copy link

trafium commented May 26, 2021

Could 01 possibly be interpreted as non-numeric prerelease version and thus valid?

UPD: I guess Identifiers consisting of only digits are compared numerically. rule says otherwise.

@vovtz
Copy link

vovtz commented Sep 2, 2021

Same goes for empty ‘identifiers’ (that’s what SemVer2 calls the parts between dots within the ‘prerelease’ field).

But this bug is more subtle too: although the version check field turns green with both of these invalid versions, the field below gives away that internally they are considered wrong (or cannot be processed at least), because it cannot tell what the next release version(s) will be.

image

image

image

@nikclayton
Copy link

1.0.5-rc+neko:240111.fd also reports as valid, but isn't (https://jubianchi.github.io/semver-check/#/version/1.0.5-rc%2Bneko%3A240111.fd). The : is not a valid character in build metadata.

pachli/pachli-android#372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants