Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CachedImage::triggerRepaint is called on OpenGL-based editor while animating a transform #1071

Open
1 task done
devinkerr opened this issue May 17, 2022 · 1 comment

Comments

@devinkerr
Copy link

Detailed steps on how to reproduce the bug

While animating a child component’s transform, JUCE invalidates the parent OpenGL context’s cachedImage, which causes spurious triggerRepaint calls, resulting in extra openGLRender calls (in our case we get around 90 FPS or so until it saturates the GPU).

What is the expected behaviour?

Expected behavior is to not call triggerRepaint since we are already calling it regularly (e.g. at 60 Hz)

Operating systems

macOS

What versions of the operating systems?

12.1

Architectures

x86_64, ARM

Stacktrace

No response

Plug-in formats (if applicable)

VST2, VST3, AU, AAX

Plug-in host applications (DAWs) (if applicable)

N/A

Testing on the develop branch

The bug is present on the develop branch

Code of Conduct

  • I agree to follow the Code of Conduct
@devinkerr
Copy link
Author

To add to this: another potentially spurious openGL repaint occurs when the window size is updated. In this case, renderOpenGL is called from the main thread, which seems to really slow things down for us during resize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant