Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turkish I-ı character #48

Closed
alperenbabagil opened this issue Jul 4, 2020 · 6 comments
Closed

Turkish I-ı character #48

alperenbabagil opened this issue Jul 4, 2020 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@alperenbabagil
Copy link
Contributor

When taking brand names the code lowercases it with the phone's locale. But it generates a problem in Turkish language devices. For example HUAWEI lowercased as "huaweı" and it is not equal to "huawei" obviously. I think there is no need for the phone's locale when lowercasing because device brand names are all returned in ASCII characters.

@judemanutd judemanutd self-assigned this Jul 4, 2020
@judemanutd judemanutd added the bug Something isn't working label Jul 4, 2020
@judemanutd
Copy link
Owner

Thanks for pointing this out @alperenbabagil , I'm a little busy this weekend so if you can create a PR for this I'll be happy to review it.

@alperenbabagil
Copy link
Contributor Author

Hi Jude,
I cannot push a new branch

@judemanutd
Copy link
Owner

Hi Jude,
I cannot push a new branch

Fork & Create a PR

@alperenbabagil
Copy link
Contributor Author

Man.. I mean you must allow pushing new branch

@AdiMarianMutu
Copy link

AdiMarianMutu commented Jul 10, 2020

I've fixed the code in the pull request #46

@judemanutd
Copy link
Owner

Closing this one since there is no activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants