-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turkish I-ı character #48
Labels
bug
Something isn't working
Comments
Thanks for pointing this out @alperenbabagil , I'm a little busy this weekend so if you can create a PR for this I'll be happy to review it. |
Hi Jude, |
|
Man.. I mean you must allow pushing new branch |
I've fixed the code in the pull request #46 |
Closing this one since there is no activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When taking brand names the code lowercases it with the phone's locale. But it generates a problem in Turkish language devices. For example HUAWEI lowercased as "huaweı" and it is not equal to "huawei" obviously. I think there is no need for the phone's locale when lowercasing because device brand names are all returned in ASCII characters.
The text was updated successfully, but these errors were encountered: