Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe change_struc_imp_aux should be a workfunction instead of a simple function #13

Closed
PhilippRue opened this issue Nov 28, 2018 · 1 comment
Assignees

Comments

@PhilippRue
Copy link
Member

If we change the definition of the function

def change_struc_imp_aux_wf(struc, imp_info): # Note: works for single imp at center only!

to add the @wf decorator just before the function definition, aiida should automatically recognize that inputs and outputs are nodes in the database and create the corresponding database nodes with links. This will improve the readability of the workflow afterwards since it makes it clearer to track how input and auxiliary structures are connected.

Here wf should be imported like this:

from aiida.work.workfunctions import workfunction as wf
fBert31 pushed a commit that referenced this issue Nov 29, 2018
List of changes:

- fixed issue #13 (change_struc_imp_aux is now a workfunction)

- more information in workflow_info node of kkr_imp workflow

- better graph structure for the kkr_imp_sub workflow

- new input in get_inputs_kkrimp and get_inputs_common
@fBert31
Copy link
Collaborator

fBert31 commented Nov 29, 2018

Fixed in commit ab13079b08a6061db893856f246c67fe5219f496

@fBert31 fBert31 closed this as completed Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants