Handle request-start header in microseconds and nanoseconds #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-sully
reviewed
Mar 14, 2023
| @@ -20,15 +24,23 @@ def started_at | |||
| if @request_start_header | |||
| # There are several variants of this header. We handle these: | |||
| # - whole milliseconds (Heroku) | |||
| # - whole microseconds (???) | |||
There was a problem hiding this comment.
Prior to this PR, my code comment said "nanoseconds", but my implementation handled "microseconds". I'm not even sure which one Render uses. I can't find it documented anywhere.
There was a problem hiding this comment.
Well dang.
But I think we're well within safe constraints. Interesting they don't mention it anywhere though. Maybe they don't anticipate people using that header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure wither Render uses microseconds or nanoseconds, so we'll handle both.