Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Replace temporary lockfile name properly on Windows #76

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

GeeTransit
Copy link
Contributor

Hello!

I'm using your plugin on Windows and it works really well. However, it doesn't properly detect the temporary requirements.in filename, leading to this in my lockfile:

httpx==0.22.0
    # via -r C:\Users\xxx\AppData\Local\Temp\tmp_kn984om\test-two.in

The regex used to replace this is rf"-r \S*/{self.environment.name}\.in", which doesn't account for backslashes. I changed it to rf"-r \S*[\\/]{self.environment.name}\.in".

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (7ac1068) to head (1e5c855).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   95.81%   95.88%   +0.06%     
==========================================
  Files          18       18              
  Lines         956      972      +16     
  Branches      160      160              
==========================================
+ Hits          916      932      +16     
  Misses         25       25              
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juftin
Copy link
Owner

juftin commented Feb 26, 2024

Nice! Thank you very much. I'm honestly terrible with RegEx, this was super useful.

@juftin juftin merged commit 8a7874f into juftin:main Feb 26, 2024
12 checks passed
github-actions bot added a commit that referenced this pull request Feb 26, 2024
# [v1.11.1](v1.11.0...v1.11.1) (2024-02-26)

## 🐛 Bug Fixes
- [`8a7874f`](8a7874f)  Replace temporary lockfile name properly on Windows (Issues: [`#76`](#76))

[skip ci]
@juftin
Copy link
Owner

juftin commented Feb 26, 2024

🎉 This PR is included in version 1.11.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants