Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 #40

Closed
13 tasks
TremayneChrist opened this issue Feb 26, 2019 · 1 comment
Closed
13 tasks

v2 #40

TremayneChrist opened this issue Feb 26, 2019 · 1 comment
Labels
enhancement New feature or request spec

Comments

@TremayneChrist
Copy link
Member

This major version upgrade will update the library to cover the new shape of the ResizeObserverEntry.

entry = {
  target: <element>,
  contentRect: { /* v1 backwards compat */ },
  borderBox: null,
  contentBox: {
    inline: 300,
    block: 200
  }
}

Confirmed changes:

  • Remove scrollBox support.
  • Remove devicePixelBorderBox support.
  • Return null for unobserved boxes.
  • Rename borderBoxSize to borderBox.
  • Rename contentSize to contentBox.
  • Rename inlineSize to inline.
  • Rename blockSize to block.
  • Update internal names for box sizes.
  • Remove canvas checks for device-pixel-border-box.

Needs confirmation:

  • Create new key based on element and options?
  • Observing the same element multiple times, with different options, is supported?

Additional updates:

  • Update readme examples and link to v1 version of readme
  • Updated all demos to use v2

Potential upcoming changes:

  • Fragmentation of element boxes (unlikely to be anytime soon).
  • Add offset information to entry.
@TremayneChrist TremayneChrist added enhancement New feature or request spec labels Feb 26, 2019
@TremayneChrist TremayneChrist pinned this issue Feb 26, 2019
@TremayneChrist TremayneChrist mentioned this issue Feb 26, 2019
Closed
@TremayneChrist
Copy link
Member Author

Closing as this can be followed in #41

@TremayneChrist TremayneChrist unpinned this issue Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TremayneChrist