Make identifiers pretty instead of mangled.

[tbranyen]

Run the moduleName through a function that can generate a pretty and valid JavaScript identifier. This will help avoid the need to mangle the identifier for uniqueness.

[jugglinmike]

I was thinking about this, and I´m not sure how we could do it reliably. A naive approach might transform the module ID 1a-b;c to _1a_b_c, but then we would have to avoid collisions with a module originally named _1a_b_c.

Instead, could we just define a __MODULES__ namespace and attach modules as properties to that using moduleNames as a key directly?

[tbranyen]

I agree. If you specify a namespace, we shouldn't have to mangle anything, we can instead directly attach:

__MODULES__["Number"] = {};
__MODULES__["123_INVALID--;IDENTIFER"] = {};

[jugglinmike]

Will we still need to procedurally generate names for anonymous modules?

[tbranyen]

We can remove generated identifiers if we are okay with enforcing a namespace. That may be a better way of going about this anyways.

[jugglinmike]

Do we generate names for anonymous modules from the file path?

[jugglinmike]

Rather: will we generate names for anonymous modules from the file path?