Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"mocha": ">=2.0.0" is breaking the build as mocha 4.0.0 has breaking change. #70

Closed
kumarrishav opened this issue Oct 4, 2017 · 1 comment
Closed

"mocha": ">=2.0.0" is breaking the build as mocha 4.0.0 has breaking change. #70

kumarrishav opened this issue Oct 4, 2017 · 1 comment

Comments

@kumarrishav
Copy link

kumarrishav commented Oct 4, 2017 •
edited

https://github.com/juhovh/mocha-jenkins-reporter/blob/0.1.9/package.json#L22
instead we should have "mocha": "^3.0.0"

Also, having version like this: "mocha": ">=2.0.0" can block in future (can cause build failure) as mocha version bump might breaking change.
@kumarrishav kumarrishav mentioned this issue Oct 4, 2017
Merged
@dostu dostu mentioned this issue Oct 6, 2017
Merged
@palfrey
Copy link

palfrey commented Dec 11, 2017

Fixed by #71

@jvah jvah closed this as completed Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@palfrey @jvah @kumarrishav