Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check settings on Redis #16

Closed
davies opened this issue Jan 11, 2021 · 5 comments · Fixed by #63
Closed

Check settings on Redis #16

davies opened this issue Jan 11, 2021 · 5 comments · Fixed by #63
Assignees
Labels
kind/feature New feature or request

Comments

@davies
Copy link
Contributor

davies commented Jan 11, 2021

What would you like to be added:

After connected to Redis, check the following settings on redis:

  1. AOF is ON
  2. RDB is ON
  3. no in cluster mode (cluster_enabled is 0)
  4. maxmemory_policy is set to noeviction
  5. show a warning if it's not replicated
  6. version should be >= 2.2

Why is this needed:

Redis is responsible for persistence of metadata, so it should NOT lose any data, otherwise the data in JuiceFS will be lost.

@suzaku
Copy link
Contributor

suzaku commented Jan 12, 2021

How do we check if RDB is disabled? The only related configuration seems to be the "save" interval.

@vision9527
Copy link

What is the best redis's deployment strategy? Is there some more detail about it?

@davies
Copy link
Contributor Author

davies commented Jan 12, 2021

How do we check if RDB is disabled? The only related configuration seems to be the "save" interval.

Yeah, may be just ignore it (assume RDB is always enabled).

@davies
Copy link
Contributor Author

davies commented Jan 12, 2021

What is the best redis's deployment strategy? Is there some more detail about it?

There should be many articles on this topic, for example, https://redis.io/topics/persistence

We can build a best practice for JuiceFS.

@suzaku
Copy link
Contributor

suzaku commented Jan 12, 2021

How do we check if RDB is disabled? The only related configuration seems to be the "save" interval.

Yeah, may be just ignore it (assume RDB is always enabled).

Seems straight forward enough, could you assign this issue to me? I'll work on it when I have some time to spare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants