Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not use traffic lane direction #8

Closed
JuniorDjjr opened this issue Oct 9, 2022 · 7 comments
Closed

Should not use traffic lane direction #8

JuniorDjjr opened this issue Oct 9, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@JuniorDjjr
Copy link

JuniorDjjr commented Oct 9, 2022

I'm glad you're continuing this project, as it's something really important for the game.

But the idea of respecting lane direction is terrible. This should be an option in the .ini, and disabled by default. It is only useful for people who play the game respecting the traffic laws (roleplay). And even in this case it's bad, because the game's map wasn't designed for that.

@juicermv juicermv self-assigned this Nov 7, 2022
@juicermv juicermv added the enhancement New feature or request label Nov 7, 2022
@juicermv
Copy link
Owner

juicermv commented Nov 8, 2022

Perhaps I could calculate both and pick the shortest one of the two (in addition to having the option to choose one or the other). Will implement.

@juicermv juicermv closed this as completed Nov 8, 2022
@JuniorDjjr
Copy link
Author

Perhaps I could calculate both and pick the shortest one of the two (in addition to having the option to choose one or the other). Will implement.

What's the point of calculating both and finding the closest?

You would be calculating X and Y (2 lanes), and then only X (only valid dir lane), but in X and Y you have already calculated X.

That is, there is no way X and Y give a longer path than only X.

@juicermv
Copy link
Owner

juicermv commented Nov 9, 2022

I meant I calculate both and choose the one that's shortest meaning I calculate once with traffic direction enabled, and then once without it, and then pick the shortest of the two.

@JuniorDjjr
Copy link
Author

Yes I understood that.

Traffic direction enabled: X (only correct lane)
Traffic direction disabled: XY (correct and incorrect lane)

If you calculate only "disabled", you are already calculated both sides, then for sure you will have the shortest way.

@juicermv
Copy link
Owner

juicermv commented Nov 9, 2022

Oh that's right lol, my mistake.

@juicermv juicermv added this to the 1.3 milestone Nov 24, 2022
@juicermv
Copy link
Owner

Re-opening this so it shows up on the milestone thing.

@juicermv juicermv reopened this Dec 12, 2022
@juicermv
Copy link
Owner

Added the toggle in the config but it's gonna be on by default as most people seem to prefer it that way (judging by the comments on mixmods). Releasing soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants