Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charm-env needs option to clarify ambiguous cases #109

Closed
johnsca opened this issue Mar 21, 2018 · 0 comments · Fixed by #123
Closed

charm-env needs option to clarify ambiguous cases #109

johnsca opened this issue Mar 21, 2018 · 0 comments · Fixed by #123

Comments

@johnsca
Copy link
Contributor

johnsca commented Mar 21, 2018

If you need to run a charm tool outside of a Juju hook context, charm-env has to guess which charm directory to use, and it can only work properly if the charm is the one and only principle unit on the machine (i.e., not a subordinate, and no hulk-smashes). It should support a parameter to allow the charm author to disambiguate those cases by indicating the charm name (NB: not the unit name). Something like:

#!/usr/local/sbin/charm-env --charm foo python
johnsca added a commit that referenced this issue Sep 21, 2018
@johnsca
Add --charm option to charm-env
f73afcc 
To disambiguate cases where there are multiple charms co-located on a
single machine, add a `--charm` option to the `charm-env` command.

Note that this specifies the name of the charm, not the application or
unit name, since the latter two change depending on how it is deployed.

Fixes #109
@johnsca johnsca mentioned this issue Sep 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --charm option to charm-env canonical/layer-basic
1 participant
@johnsca