Retry failed apt install during bootstrap #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally, apt would not be able to acquire the lock and would fail, only to succeed on the next attempt. Fixes #91
|
LGTM 👍 |
mbruzek
reviewed
Apr 7, 2017
| if attempt == 2: # third attempt | ||
| raise | ||
| sleep(5) | ||
| else: |
There was a problem hiding this comment.
Is it just me or is this else not at the right indentation level?
There was a problem hiding this comment.
I answered this via other channels, but for posterity:
The else here is on the try / except block, and will be executed if there are no exceptions raised. It is almost the same thing as putting the break inside the try block except that exceptions raised in the else block are not caught by any except blocks (though in this case, break can't raise a CalledProcessError anyway).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, apt would not be able to acquire the lock and would fail, only to succeed on the next attempt.
Fixes #91