Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

Use sane bundle names on result page. #120

Open
seman opened this issue Mar 23, 2017 · 4 comments
Open

Use sane bundle names on result page. #120

seman opened this issue Mar 23, 2017 · 4 comments

Comments

@seman
Copy link
Contributor

seman commented Mar 23, 2017

No description provided.

@seman seman changed the title Use sane bundle name on result page. Use sane bundle names on result page. Mar 23, 2017
@kwmonroe
Copy link
Contributor

@seman i don't think you could be less descriptive if you tried! What's the insane thing you're seeing, and what's the sane thing you want?

@seman
Copy link
Contributor Author

seman commented Mar 23, 2017

Just saying instead of cwr_charm_commit_mysql_in_cs_wiki_simple, change the name to wiki-simple on result page (image #1). Also when clicking on the bundle name on "report.html" (image #2), it should link back to the bundle in charmstore or repository.

sf

s3

@kwmonroe
Copy link
Contributor

Just saying instead of cwr_charm_commit_mysql_in_cs_wiki_simple, change the name to wiki-simple

I'm not a fan of that because what if you want to test mediawiki in the same bundle context? I think it's nice that you'd have both:

cwr_charm_commit_mediawiki_in_cs_wiki_simple
cwr_charm_commit_mysql_in_cs_wiki_simple

So you'd know exactly what the charm and bundle context is being executed by the job name.

clicking on the bundle name on "report.html" should link back to the bundle in charmstore or repository.

Agreed. How does cwr.jujucharms.com do that? I assumed the report.html page was written by cloud-weather-report, but I'm not sure how it knows where to link.

@johnsca
Copy link
Contributor

johnsca commented Mar 24, 2017

I, too, really dislike the underscore-heavy presentation in the reports, but between the collision issue that @kwmonroe mentioned and the need to be able to match jobs up to the output directory in a consistent manner, I couldn't come up with a better way to have them be presented nicely without the underscores and namespacing.

Things to consider: being able to see a job in the CWR report and being able to easily match that job up in Jenkins, being able to reference said job in the API, being able to distinguish jobs that use the same bundle but are building and testing different specific charms within the bundle, avoiding corner cases where special characters in the title leak out and break things on the file system, avoiding a lot of duplicate logic throughout the codebase for normalizing titles to jobs names, etc.

But if we can come up with a solution that improves the presentation while addressing those issues, I'm all for it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants