Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying the Service Block object #10

Closed
ajstarks opened this issue Dec 10, 2014 · 5 comments
Closed

Simplifying the Service Block object #10

ajstarks opened this issue Dec 10, 2014 · 5 comments

Comments

@ajstarks
Copy link

Would a simple roundrect work better than the complicated path for the serviceBlock object?

@mitechie
Copy link
Contributor

This might be true. The visualization is drive by the UX team and their 'squircle' requirements. Is there something that the current work that it's doing poorly that should be corrected?

@ajstarks
Copy link
Author

I think so. It would be helpful to see the entire visualization. Can you send a sample?
One the design principles of SVGo was to use the built-in objects and avoid the "pathitis" so prevalent in the output of illustration programs.

@ajstarks
Copy link
Author

here's a sample:

package main

import (
    "os"
    "github.com/ajstarks/svgo"
)


func main() {
    canvas := svg.New(os.Stdout)
    width := 500
    height := 500


    canvas.Start(width, height)
    canvas.Rect(0,0,width,height,"fill:white")

    canvas.Def()
    canvas.Gid("serviceBlock")
    canvas.Roundrect(0,0,200,210,40,40,"stroke-width:3;stroke:gray;fill:white")
    canvas.Gend()
    canvas.DefEnd()

    canvas.Use(10,10,"#serviceBlock")
    canvas.Use(80,80,"#serviceBlock")

    canvas.End()
}

@makyo
Copy link
Contributor

makyo commented Apr 6, 2015

This is sort of addressed by #23 which moves the asset of the service block to its own file which can thus be included. It doesn't really alleviate pathitis, but it does keep design happy, and helps us out so that we're not rewriting their assets in SVGo-ese. We can simply drop design's assets in there, then canvas.Use them down the road.

@makyo
Copy link
Contributor

makyo commented Feb 9, 2016

Obviated by #41

@makyo makyo closed this as completed Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants