Renamed variable for clarity. Exporting useful regexes. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assuming the existing tests exercise this change; LGTM |
|
LGTM |
| revisionSnippet = "(-1|0|[1-9][0-9]*)" | ||
| ) | ||
|
|
||
| var ( |
There was a problem hiding this comment.
Can we please merge this var block with the previous?
| SeriesSnippet = "[a-z]+([a-z0-9]+)?" | ||
|
|
||
| // CharmNameSnippet is a regular expression representing charm name | ||
| CharmNameSnippet = "[a-z][a-z0-9]*(-[a-z0-9]*[a-z][a-z0-9]*)*" | ||
| ) | ||
|
|
||
| var validCharmRegEx = regexp.MustCompile("^(" + |
There was a problem hiding this comment.
I think this should probably be validCharmURLRegEx.
I think it should also appear above all the component parts. I found it much easier to understand what each regex represents when I saw the whole thing then the snippets
There was a problem hiding this comment.
Also I think it belongs in the same var block as the snippets above
|
LGTM, merge at your leisure. |
anastasiamac
added a commit
that referenced
this pull request
Dec 17, 2014
Renamed variable for clarity. Exporting useful regexes. Grouped vars in blocks for readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exporting regular expressions for re-use outside of names.
Renamed user validPart for clarity and reusability.