New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libjuju 2.6.1 breaks juju.model.Model.get_config() against juju 2.6.6 model #344
Comments
Thanks for this, I'm trying to understand the code you're running/using the library with. Is it possible to get at the test details in the traceback. My reading of things is that the config is looking for the entire mapped config vs a single value. I'm wondering if this is a case of something that used to either say it was working, but not really, or something that worked accidentally but now that we're more strict should be tweaked going forward. Thanks for the additional details! |
Of course the issue is that the code you've got here seems to just be reading config and not setting anything... |
Ok, just to note what the code is doing in L51
So it's just doing |
Yes, exactly. Sorry if that was unclear from the original note. I've edited to improve formatting of the original issue. I believe the issue is a missing allowed instance-type for the ConfigValue object's 'value_' of type 'str' here:
|
@afreiberger it turns out there was a bug in the way we generated the facade and definitions code. The problem was that certain parameter fields have the type of Thanks for the detailed report, it helped diagnosing the issue. |
Hello.
|
@afreiberger, @ovod88 2.6.2 has been released with the fixes for the Let me know if you have any other issues. |
The following code works against juju==2.6.0, but just started failing today against juju==2.6.1.
It appears that the code that validates ConfigValues is now expecting value to be either a dict or a set, but does not allow for values to be strings.
I've reverted my testing environment to use juju==2.6.0 as a workaround.
Here is my testing traceback:
The text was updated successfully, but these errors were encountered: