Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd bug after updating Gamemaker to 2024.2 #518

Closed
PhoenixAndStuf opened this issue Mar 5, 2024 · 1 comment
Closed

Odd bug after updating Gamemaker to 2024.2 #518

PhoenixAndStuf opened this issue Mar 5, 2024 · 1 comment
Labels
bug 😅 Juju did a bad thing

Comments

@PhoenixAndStuf
Copy link

PhoenixAndStuf commented Mar 5, 2024

As soon as I launch my game, I get an error message saying:

ERROR in
action number 1
of Create Event
for object oGame:

ds_map_exists argument 1 incorrect type (struct) expecting a ds_map
 at gml_Script_scribble_typists_add_event (line 33) -     if (ds_map_exists(__scribble_config_colours(), _name))
############################################################################################
gml_Script_scribble_typists_add_event (line 33)
gml_Object_oGame_Create_0 (line 19) - scribble_typists_add_event("screenshake", scribbleScreenShake);

I looked into the code, and there are 3 of these if statements:

if (ds_map_exists(__scribble_config_colours(), _name))
{
    __scribble_trace("Warning! Event name \"" + _name + "\" has already been defined as a colour");
    exit;
}

if (ds_map_exists(__scribble_get_effects_map(), _name))
{
    __scribble_trace("Warning! Event name \"" + _name + "\" has already been defined as an effect");
    exit;
}

if (ds_map_exists(__scribble_get_macros_map(), _name))
{
    __scribble_trace("Warning! Macro name \"" + _name + "\" has already been defined as a macro");
    exit;
}

Since the config colors function for example returns a struct, It's complaining about there being a struct passed the the function, ds_map_exists();. Wouldn't you use struct_exists(); with the same arguments? Very odd. I wasn't tampering with any of the internal code, just updated Gamemaker...

@JujuAdams JujuAdams added the bug 😅 Juju did a bad thing label Mar 6, 2024
@JujuAdams
Copy link
Owner

Fixed in 8.7.1 https://github.com/JujuAdams/Scribble/releases/tag/8.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 😅 Juju did a bad thing
Projects
None yet
Development

No branches or pull requests

2 participants