Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add threads argument #51

Open
omus opened this issue Nov 4, 2021 · 2 comments
Open

Add threads argument #51

omus opened this issue Nov 4, 2021 · 2 comments

Comments

@omus
Copy link
Contributor

omus commented Nov 4, 2021

Currently enabling threads using this action require you to set the enviromental variable JULIA_NUM_THREADS. Although this does work there is no way to use this variable to specify "auto" on Julia version < 1.7. It would be great to have support for a threads argument that lets you specify julia --threads which would allow for use of "auto" on earlier Julia versions.

@DilumAluthge
Copy link
Member

I wonder if we should just have an input named cmd_line_flags that lets the user pass whatever flags they want.

@SaschaMann
Copy link
Member

I wonder if we should just have an input named cmd_line_flags that lets the user pass whatever flags they want.

I have thought about that before but I kinda don't see the point of even using this action if you need to customise your build script that much. At that point you might as well just write whatever you're trying to run directly into the workflow.

That said, I don't have a strong opinion on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants