Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve loop checks #208

Merged
merged 2 commits into from Oct 6, 2020
Merged

improve loop checks #208

merged 2 commits into from Oct 6, 2020

Conversation

ZacLN
Copy link
Contributor

@ZacLN ZacLN commented Sep 30, 2020

Checks that we are actually progressing along the input text (source code) in all while loops - i.e. that there is no case where we accidentally seek backwards. The previous approach was poor.

@ZacLN ZacLN added the bug label Sep 30, 2020
@ZacLN ZacLN added this to the Next Patch milestone Sep 30, 2020
@ZacLN ZacLN added this to In progress in Current via automation Sep 30, 2020
@ZacLN ZacLN self-assigned this Sep 30, 2020
davidanthoff
davidanthoff approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

And then we should push out a new version with this right away, correct?

Current automation moved this from In progress to Approved, waiting for merge Oct 6, 2020
@davidanthoff davidanthoff merged commit fc030f1 into master Oct 6, 2020
Current automation moved this from Approved, waiting for merge to Done Oct 6, 2020
@davidanthoff davidanthoff deleted the trips branch October 6, 2020 18:24
@oppo-source oppo-source removed the request for review from a team April 16, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidanthoff davidanthoff davidanthoff approved these changes

Assignees

@ZacLN ZacLN

Labels
bug
Projects
No open projects
Current
  
Done
Milestone
Next Bugfix Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZacLN @davidanthoff