URI is not valid for textDocument/definition outside a package

[non-Jedi]

A file URI is required to be absolute as far as I can tell. Even if it isn't, the language-server client doesn't know what directory to resolve a relative file URI to.

If you create a file main.jl:

include("utils.jl")

lang = to_upper("julia")

and utils.jl:

to_upper(x) = uppercase(x)

And request textDocument/definition of to_upper from within main.jl, the URI is given as "file://utils.jl" instead of the full path that it should be:

client-request (id:62) Tue May  5 08:00:46 2020:
(:jsonrpc "2.0" :id 62 :method "textDocument/definition" :params
          (:textDocument
           (:uri "file:///home/adam/tmp/main.jl")
           :position
           (:line 2 :character 10)))

server-reply (id:62) Tue May  5 08:00:46 2020:
(:id 62 :jsonrpc "2.0" :result
     [(:uri "file://utils.jl" :range
            (:start
             (:line 0 :character 0)
             :end
             (:line 2 :character 3)))])

Thanks to @prasannakog for the reproducer at gdkrmr/lsp-julia#25 (comment)

[ZacLN]

Hiya, a couple questions to help me understand this.

• Could you elaborate a bit on what you mean by 'works inside a package' on the downstream issue?
• Are these files saved (in the sense of having sent a didSave notification to the server? And if so are both files saved with a full URI?

[non-Jedi]

• If main.jl is instead Main.jl inside the src directory of a package (and the contents are wrapped in module Main), the full URI is given for utils.jl e.g. /home/adam/tmp/Main/src/utils.jl. The difference might have to do with the fact that the environment path passed to LanguageServerInstance is the path to the default environment when outside a package (different than rootPath/rootURI sent during initialize)?
• Behavior is the same whether or not a didSave notification has been sent. When a didSave notification is sent, it includes the full URI:

client-notification Tue May  5 10:29:26 2020:
(:jsonrpc "2.0" :method "textDocument/didSave" :params
          (:text "to_upper(x) = uppercase(x)\n\n" :textDocument
                 (:uri "file:///home/adam/tmp/utils.jl")))

[ZacLN]

As per the other issue, could you send me some logs from initialization through to the problem (maybe as a gist?)

[non-Jedi]

Here you go: https://gist.github.com/non-Jedi/fd8c9f5e31f9cac9e47d7a81d142a4b8

Thanks for taking a look. :)

[non-Jedi]

Per report on discourse this is still a problem on master. I haven't personally replicated it though.

[ffevotte]

Ah, sorry, it looks like I have been too careless when doing tests: I can now confirm that this issue is indeed fixed.

I'm very sorry for the noise.

[pfitzseb]

Thanks for reporting back! :)