Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to move caching into the cloud #162

Closed
non-Jedi opened this issue Jun 1, 2020 · 3 comments
Closed

Plans to move caching into the cloud #162

non-Jedi opened this issue Jun 1, 2020 · 3 comments

Comments

@non-Jedi
Copy link
Member

non-Jedi commented Jun 1, 2020

@davidanthoff I saw you mention in #160 and #161 that you plan to move caching into the cloud. Could you expand a little bit on the proposed architecture for doing so? Culturally I think that several of the downstream clients for LanguageServer.jl other than vscode will tend to be more uncomfortable with such a change. Specifically I'd like to know if the thought is that:

  • Caching of symbols on user's machines continues to be the default for LanguageServer.jl, but vscode will provide a mechanism to download caches
  • Caching of symbols on user's machines continues to be the default for LanguageServer.jl, but an option can be passed to LanguageServerInstance to download caches.
  • LanguageServer.jl will default to downloading caches
  • Something else I haven't considered
@ZacLN
Copy link
Contributor

ZacLN commented Jun 1, 2020

Somewhere in region of the first two of those bullets I'd say.

@davidanthoff
Copy link
Member

Yes, this will definitely be optional! The way I think about this right now is that currently we have one way to create these cache files (local indexing), going forward we'll have to (download from cloud and local indexing). Even for VS Code we will want to continue to have the local indexing option, for example when a user is offline I imagine that the LS would first try to download the cache file from the cloud, but when that doesn't work because there is no internet, it would fall back to the usual local indexing mechanism.

So we can definitely have an option that just disables the cloud download, which would essentially be equivalent to the mode for VS Code where the internet is down.

@davidanthoff
Copy link
Member

Oh, and closing this as a duplicate of #108.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants