Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: highlight where parsing error occurs #125

Closed
sbromberger opened this issue Jul 20, 2017 · 4 comments
Closed

feature request: highlight where parsing error occurs #125

sbromberger opened this issue Jul 20, 2017 · 4 comments

Comments

@sbromberger
Copy link

Right now if you start a docstring with triple quotes, until you put the closing quotes in, the entire file will be underlined in red as a parsing error. (Same goes for any block without a corresponding end.) This is really distracting.

Would it be possible to just highlight the section of code that is "in error"? (or, as an alternative, when a block starts, automatically insert end statements or closing quotes as necessary?)

@ZacLN
Copy link
Contributor

ZacLN commented Jul 20, 2017

Oops, this was turned off for some reason. #126

@davidanthoff davidanthoff added this to the Backlog milestone Jul 20, 2017
@ZacLN
Copy link
Contributor

ZacLN commented Jul 26, 2017

So I've been using this with the error appearing at the literal point of parsing failure which, more often than not will be at the end of the file and so is not that helpful.

What are the thoughts on underlining in green the start of the expression (that eventually fails to parse) and switching to red after the actual point of failure?

@sbromberger
Copy link
Author

My preference would be to make red what you're proposing to make green, and not do anything with what you're proposing to make red.

@davidanthoff
Copy link
Member

We should take a look at the linters for other languages in VS Code and what they do, especially the "official" ones developed by Microsoft. They probably thought hard about it and we can just follow their lead :)

@davidanthoff davidanthoff modified the milestones: v0.2.0, Backlog Aug 8, 2017
@ZacLN ZacLN modified the milestones: v0.2.0, Backlog Sep 26, 2017
@ZacLN ZacLN closed this as completed Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants