Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadratically shifted bases #103

Closed
TSGut opened this issue Jul 7, 2022 · 4 comments
Closed

Quadratically shifted bases #103

TSGut opened this issue Jul 7, 2022 · 4 comments

Comments

@TSGut
Copy link
Member

TSGut commented Jul 7, 2022

I want to use $P(2x^2-1)$. I had this working when the repo was still OrthogonalPolynomialsQuasi.jl but some changes since have stopped it from working with my setup and I don't want to use the old repo. I think this should just be easy to do out of the box in this package, especially given how ubiquitous $P(2x^2-1)$ is for rotationally symmetric bases.

It seems a Chebyhev quadratic shift is implemented in the tests, see

struct QuadraticMap{T} <: Map{T} end

I think this should be low effort to get working for at least general Jacobi polynomials. Any objections to me adding this functionality to the package itself rather than just have it defined in tests?

Once we do this I would also be happy to type up some documentation on shifted bases. 😁

@dlfivefifty
Copy link
Member

Are mappings really the right way to do this? It might be better to think of these as SymmetricLegendre living in SymmetricOrthogonalPolynomials.jl as then the symmetry aspect is explicit....

@TSGut
Copy link
Member Author

TSGut commented Jul 7, 2022

Do you mean "the right way to do this" in terms of package placement or in terms of the underlying implementation? Implementation wise I think it's a pretty solid way of doing it. I'm open to better ideas if that is what you meant.

Basically I'm trying to update and open source our higher dimensional equilibrium measures stuff in something like EquilibriumMeasures.jl but I need these bases working before I can do that. Making this depend on a for now private repo would complicate things, although I do agree that it would make sense for these radially symmetric bases to live in SymmetricOrthogonalPolynomials.jl eventually.

So if that is the plan, then for now I can just have the required bases explicitly coded into EquilibriumMeasures.jl until SymmetricOrthogonalPolynomials.jl is more mature and then move it there?

@dlfivefifty
Copy link
Member

Yes I think that's sensible... I think it would be a mistake to widen the scope of this package TBH

@TSGut
Copy link
Member Author

TSGut commented Jul 7, 2022

Great, I'll start work on including it in EquilibriumMeasures.jl for now and will open an issue in SymmetricOrthogonalPolynomials.jl to remind myself to add it there when we know more about how that package will be organized.

@TSGut TSGut closed this as completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants