Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make warmup function's verbose optional argument a keyword argument for consistency #21

Closed
musm opened this issue Aug 31, 2016 · 1 comment · Fixed by #57
Closed

Make warmup function's verbose optional argument a keyword argument for consistency #21

musm opened this issue Aug 31, 2016 · 1 comment · Fixed by #57

Comments

@musm
Copy link
Contributor

musm commented Aug 31, 2016

Makes sense since run has this optional keyword argument
@musm musm changed the title Need verbose option on warmup Need verbose keyword argument option for warmup function Aug 31, 2016
@jrevels
Copy link
Member

jrevels commented Aug 31, 2016

It does have a verbose option, but it should be made a keyword argument instead of an optional argument for the sake of consistency.

@jrevels jrevels changed the title Need verbose keyword argument option for warmup function Make warmup function's verbose optional argument a keyword argument for consistency Aug 31, 2016
@musm musm mentioned this issue May 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make warmup verbose optional argument
2 participants
@jrevels @musm