Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plolty version #11

Closed
disberd opened this issue Mar 13, 2022 · 2 comments
Closed

plolty version #11

disberd opened this issue Mar 13, 2022 · 2 comments

Comments

@disberd
Copy link

disberd commented Mar 13, 2022

Hello!

Very cool package for minimizing TTF plot!
I have been playing around a lot with plotly and also started working recently on wrapping around PlotlyBase.jl to optimize plotting in Pluto with plolty (https://github.com/JuliaPluto/PlutoPlotly.jl)

I might consider using your package instead of PlotlyBase.jl as base, or even try to see if I can get to add some Pluto-specific optimizations as PR to this if the concept is OK with you and they are light enough!

Apart from this introduction, I was going through your code and noticed that at least for the CDN show option which is the default, you are pointing to plotly-latest for the plotly version.
I do not know if this was a deliberate choice to keep the library to version 1, but since plotly moved to version 2, one has to manually specify the version number and plolty-latest will always point to the last revision of version 1, as written here:
https://github.com/plotly/plotly.js#un-minified-versions-are-also-available-on-cdn

Please note that as of v2 the "plotly-latest" outputs (e.g. https://cdn.plot.ly/plotly-latest.min.js) will no longer be updated on the CDN, and will stay at the last v1 patch v1.58.5. Therefore, to use the CDN with plotly.js v2 and higher, you must specify an exact plotly.js version.

Would it be difficult to add some config parameter to also specify the plotly version to load? As quite a few fixes and features addition have happened since 1.58.5

@joshday
Copy link
Member

joshday commented Mar 13, 2022

I had no idea about plotly-latest being pinned to an old version! Thanks for letting me know. Feel free to give some Pluto-focused PRs!

Would it be difficult to add some config parameter to also specify the plotly version to load?

That should be straightforward to implement. I also want the default to be the most recent release.

@joshday
Copy link
Member

joshday commented Mar 15, 2022

Yesterday's release uses the most recent version of Plotly

@joshday joshday closed this as completed Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants