Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@> begin df versus @byrow! df begin #92

Closed
pdeffebach opened this issue Apr 26, 2018 · 6 comments
Closed

@> begin df versus @byrow! df begin #92

pdeffebach opened this issue Apr 26, 2018 · 6 comments

Comments

@pdeffebach
Copy link
Collaborator

This is a small gripe with DataFramesMeta

When using the linq macros, you write df = @> begin df

When using other DataFramesMeta macros, you write the begin first with df = @byrow! df begin

Any interest in changing the linq macro to be @> df begin?

@ararslan
Copy link
Member

That seems like a good idea to me. What do you think, @tshort?

@tshort
Copy link
Contributor

tshort commented Apr 26, 2018

@linq is separate from @> (that comes from Lazy.jl). So, I'm not sure what you're asking. We can't change @> as we don't own it.

@pdeffebach
Copy link
Collaborator Author

Ah i meant linq "style" chaining macro @>.

Since it comes from Lazy.jl, i understand its not realistic to change. Oh well, I can live with that.

@ararslan
Copy link
Member

Sorry for misunderstanding, I didn't realize we took it from Lazy.

@pdeffebach
Copy link
Collaborator Author

An update, you can actually use @> with the order of other things.

using DataFrames, DataFramesMeta, Lazy

df = DataFrame(rand(10, 10))
df2 = @> df begin 
@transform(y = 10)
end

So my annoyance is unmerited.

@tshort
Copy link
Contributor

tshort commented Apr 27, 2018

Good to know. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants