-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't try to save which options were used to load the data #25
Comments
It works better now, but we are still saving the options that were passed. It's mostly harmless, but unnecessary and increases the size of the index. It also adds risk of something going wrong, in case there's something strange in the options we can't deserialize (e.g. a function in a package that's not loaded anymore). |
We don't save the hash of the options in the metadata anymore. We only use it to key |
We are still saving the options themselves, as part of the chunk objects. |
Well |
We removed |
loadfiles
hashes the options passed to it to make sure we don't use invalid cached data. We should instead just warn about this when we are using cache, and allow user to sayoverwritecache=true
to invalidate it. Always load data from cache.The text was updated successfully, but these errors were encountered: