Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to save which options were used to load the data #25

Closed
shashi opened this issue Mar 30, 2017 · 5 comments
Closed

Don't try to save which options were used to load the data #25

shashi opened this issue Mar 30, 2017 · 5 comments

Comments

@shashi
Copy link
Collaborator

shashi commented Mar 30, 2017

loadfiles hashes the options passed to it to make sure we don't use invalid cached data. We should instead just warn about this when we are using cache, and allow user to say overwritecache=true to invalidate it. Always load data from cache.

@JeffBezanson
Copy link
Contributor

It works better now, but we are still saving the options that were passed. It's mostly harmless, but unnecessary and increases the size of the index. It also adds risk of something going wrong, in case there's something strange in the options we can't deserialize (e.g. a function in a package that's not loaded anymore).

@shashi shashi reopened this May 3, 2017
@shashi
Copy link
Collaborator Author

shashi commented May 4, 2017

We don't save the hash of the options in the metadata anymore. We only use it to key _read_cache dictionary - which is more harmless since objects are only needed to have the same hash in a given session and not across sessions.

@shashi shashi closed this as completed May 4, 2017
@JeffBezanson
Copy link
Contributor

We are still saving the options themselves, as part of the chunk objects.

@shashi shashi reopened this May 4, 2017
@shashi
Copy link
Collaborator Author

shashi commented May 4, 2017

Well usecache=false should make that get overwritten as well. I'm now a bit unclear what we should be doing instead.

@shashi
Copy link
Collaborator Author

shashi commented May 29, 2018

We removed usecache.

@shashi shashi closed this as completed May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants