Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"." is still parsed as 0.0 #53

Closed
andreasnoack opened this issue May 11, 2020 · 1 comment · Fixed by #54
Closed

"." is still parsed as 0.0 #53

andreasnoack opened this issue May 11, 2020 · 1 comment · Fixed by #54

Comments

@andreasnoack
Copy link
Member

Looks like #50 didn't fix this completely

julia> CSV.read("/Users/andreasnoack/Desktop/testdot.csv")
1×2 DataFrames.DataFrame
│ Row │ a       │  b     │
│     │ Float64 │ String │
├─────┼─────────┼────────┤
│ 1   │ 0.0     │  .     │

julia> readlines("/Users/andreasnoack/Desktop/testdot.csv")
2-element Array{String,1}:
 "a, b"
 "., ."
@quinnj
Copy link
Member

quinnj commented May 11, 2020

Yeah weird, it looks like it only does this when there are multiple columns and the first column as the single .. I'll investigate, but I think this is probably a CSV.jl issue.

quinnj added a commit that referenced this issue May 14, 2020
@quinnj
Fix successful parsing of single decimal point as valid float
db66783 
Fixes #53. The issue here is for a single decimal point that was
followed by a delimiter, we weren't hitting the normal code paths like
EOF that marked this invalid. We use the `ndigits` variable that tracks
how many digits we've parsed to check to ensure we've parsed _some_
digits before marking INVALID.
@quinnj quinnj mentioned this issue May 14, 2020
Merged
quinnj added a commit that referenced this issue May 14, 2020
@quinnj
Fix successful parsing of single decimal point as valid float (#54)
42211d2 
Fixes #53. The issue here is for a single decimal point that was
followed by a delimiter, we weren't hitting the normal code paths like
EOF that marked this invalid. We use the `ndigits` variable that tracks
how many digits we've parsed to check to ensure we've parsed _some_
digits before marking INVALID.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix successful parsing of single decimal point as valid float JuliaData/Parsers.jl
2 participants
@andreasnoack @quinnj