Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing on Julia 1.3 and nightly #51

Closed
DilumAluthge opened this issue Jul 26, 2019 · 0 comments
Closed

Tests are failing on Julia 1.3 and nightly #51

DilumAluthge opened this issue Jul 26, 2019 · 0 comments

Comments

@DilumAluthge
Copy link
Contributor

The test failure is on line 27 of runtests.jl.

The issue seems to be that in Julia 1.2 and earlier, test has 4 callsites (regardless of the value of optimize). However, in Julia 1.3, test has 5 callsites if optimize is true and 4 callsites if optimize is false.

The extra call is to Random.default_rng.

julia> callsites = find_callsites_by_ftt(test, Tuple{})
4-element Array{Cthulhu.Callsite,1}:
 %12  = invoke dsfmt_fill_array_close1_open2!(,,)::Nothing
 %35  = invoke rand(::Union{Type{Float64}, Type{Int64}},::Int64)
 %70  = invoke mapreduce_impl(,,,,,)::Float64
 %115  = invoke mapreduce_impl(,,,,,)::Int64

julia> callsites = find_callsites_by_ftt(test, Tuple{}; optimize=false)
4-element Array{Cthulhu.Callsite,1}:
 %2  = invoke rand()::Float64
 %3  = invoke >(::Float64,::Float64)::Bool
 %9  = invoke rand(::Union{Type{Float64}, Type{Int64}},::Int64)
 %10  = invoke sum(::Union{Array{Float64,1}, Array{Int64,1}})

On Julia 1.3

5-element Array{Cthulhu.Callsite,1}:
 %4  = invoke default_rng(::Int64)::Random.MersenneTwister
 %15  = invoke dsfmt_fill_array_close1_open2!(,,)::Nothing
 %38  = invoke rand(::Union{Type{Float64}, Type{Int64}},::Int64)
 %73  = invoke mapreduce_impl(,,,,,)::Float64
 %118  = invoke mapreduce_impl(,,,,,)::Int64

julia> callsites = find_callsites_by_ftt(test, Tuple{}; optimize=false)
4-element Array{Cthulhu.Callsite,1}:
 %2  = invoke rand()::Float64
 %3  = invoke >(::Float64,::Float64)::Bool
 %9  = invoke rand(::Union{Type{Float64}, Type{Int64}},::Int64)
 %10  = invoke sum(::Union{Array{Float64,1}, Array{Int64,1}})
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants