-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doctest and CitationBibliography #34
Comments
I can certainly make it a warning, but it might be worth looking a little deeper. At least in principle, I feel like @mortenpi Do you have any general comments on how doctests and plugins should interact? |
Looking at I feel like this should probably be considered a bug in |
Opened JuliaDocs/Documenter.jl#2245 |
Looks like we'll address this in Documenter in the next release. I'm somewhat inclined to leave the How much of a blocker is this for you? Can you wait for Documenter 1.0 (and #3)? Would just changing |
Thank, @goerz, so much for this! The reason I was suggesting moving to warning the execution continued after the error (which is not what I would expect from errors). In my particular case, the error is indeed harmless because the information is not used in doctest. For this reason, this is not a big issue for us and we can certainly wait for Documenter 1.0. Thanks again! |
Downstream fix: JuliaDocs/Documenter.jl#2249 |
Having implemented JuliaDocs/Documenter.jl#2249 gave me some more detailed insight into how However, just to clarify: Does it actually make a practical difference whether the warning is generated with To get to the core of my question:
That's a personal preference, though, right? – And I'm not sure I agree. I've been using the following mental model:
So in some sense One reason I often use non-fatal It would be interesting to know if there's a general consensus in the community on whether |
See https://discourse.julialang.org/t/semantics-of-error/103760 for the philosophical discussion |
Thanks for sharing your thoughts about this. I find your mental model quite useful. I didn't think about the option of "error as a log message", and I now see the rationale behind it. |
Alright, I think I'll keep it an |
The correct solution is to just skip all the citation pipeline steps when running in
in I'll make sure to do that in a future release. |
Consider the minimum example
The returns the following error (but continues processing)
As far I can tell, there's no way to pass
CitationBibliography
to doctest. I am not sure what should be done in this case, but demoting the error to a warning seems like a good first step.The text was updated successfully, but these errors were encountered: