Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding using Dispersion is slower than necessary due to manual integration for normal cdf #397

Closed
kahaaga opened this issue Apr 7, 2024 · 0 comments · Fixed by #399
Closed

Encoding using Dispersion is slower than necessary due to manual integration for normal cdf #397

kahaaga opened this issue Apr 7, 2024 · 0 comments · Fixed by #399
Labels
encodings Related to the Encodings API performance

Comments

@kahaaga
Copy link
Member

kahaaga commented Apr 7, 2024

Switching to StatsFuns.jl's normcdf drastically decreases memory footprint and runtime. An illustrative example:

Skjermbilde 2024-04-07 kl 15 24 56

I'll submit a PR for this.
@kahaaga kahaaga added performance encodings Related to the Encodings API labels Apr 7, 2024
@kahaaga kahaaga mentioned this issue Apr 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
encodings Related to the Encodings API performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Faster normal cdf encoding JuliaDynamics/ComplexityMeasures.jl
1 participant
@kahaaga