Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Transparent statistics gathering for resources #80

Open
3 tasks
hdavid16 opened this issue Jul 13, 2022 · 1 comment · May be fixed by #94
Open
3 tasks

TODO: Transparent statistics gathering for resources #80

hdavid16 opened this issue Jul 13, 2022 · 1 comment · May be fixed by #94

Comments

@hdavid16
Copy link
Member

hdavid16 commented Jul 13, 2022

I decided to open this issue to document the TODO item on the README.

Resource statistics of interest (please edit this list as deemed pertinent):

  • utilization: number of busy servers / total servers in each resource
  • put queue length: number of items in put queue
  • get queue length: number of items in get queue
@Krastanov
Copy link
Member

@hdavid16 @BenLauwens , over the next few weeks I will start working on a version of this. I wanted to give you a heads up in case you would like to veto / modify the approach I will be taking.

I plan to create a resource type that wraps the current resource type and logs all requests to the resource. Then I plan to add some DataFrames helpers that can extract that log and post process it in various ways, giving the results in the form of a DataFrame. This would require a DataFrames weak dependency (done with Requires.jl for Julia pre-1.9 and using the new package extension functionality in Julia 1.9+).

Additions to the public API will be kept minimal so that we can modify things in the future without breaking releases. In particular, I plan to add one new public type for the resource and one new helper function for the conversion to DataFrames.

Additionally, @BenLauwens , please let me know if you prefer that this functionality is just a completely separate library.

Lastly, I know everyone is very busy so I will interpret silence as tacit approval. Of course, if it becomes necessary, feel free to block things with messages as vague as "please do not merge, I have feedback/critique, but I will need a few weeks to find the free time to write it down".

@Krastanov Krastanov linked a pull request Aug 3, 2023 that will close this issue
@Krastanov Krastanov linked a pull request Aug 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants