Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw unconditionally when matrix is singular #166

Open
andreasnoack opened this issue Aug 21, 2018 · 0 comments
Open

Don't throw unconditionally when matrix is singular #166

andreasnoack opened this issue Aug 21, 2018 · 0 comments
Labels
bug Something isn't working cuda array Stuff about CuArray.

Comments

@andreasnoack
Copy link
Member

Following up on https://github.com/JuliaGPU/CuArrays.jl/issues/107#issuecomment-414659174. The base behavior is now

julia> lu(zeros(2,2), check = true)
ERROR: SingularException(1)
Stacktrace:
 [1] checknonsingular at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/LinearAlgebra/src/factorization.jl:12 [inlined]
 [2] #lu!#97(::Bool, ::Function, ::Array{Float64,2}, ::Val{true}) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/LinearAlgebra/src/lu.jl:41
 [3] #lu! at ./none:0 [inlined]
 [4] #lu#101 at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/LinearAlgebra/src/lu.jl:142 [inlined]
 [5] #lu at ./none:0 [inlined] (repeats 2 times)
 [6] top-level scope at none:0

julia> lu(zeros(2,2), check = false)
Failed factorization of type LU{Float64,Array{Float64,2}}
@maleadt maleadt transferred this issue from JuliaGPU/CuArrays.jl May 27, 2020
@maleadt maleadt added bug Something isn't working cuda array Stuff about CuArray. labels May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuda array Stuff about CuArray.
Projects
None yet
Development

No branches or pull requests

2 participants